Netusb: Fix coverity ID178334 and add TCP retry count in debug #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print also retry count when retransmitting packets. Signed-off-by: Andrei Emeltchenko <[email protected]>
finikorg
requested review from
andyross,
jukkar,
tbursztyka and
youvedeep
as code owners
jukkar
requested changes
Oct 31, 2017
| @@ -233,41 +233,34 @@ int ecm_send(struct net_pkt *pkt) | |||
| { | |||
There was a problem hiding this comment.
Commit message is missing
Fixes #4637
Coverity-CID: 178334
There was a problem hiding this comment.
Added Coverity and bug ID
In a case we get packet without fragments return -ENODATA. The bug was discovered by Coverity. Fixes zephyrproject-rtos#4637 Coverity-CID: 178334 Signed-off-by: Andrei Emeltchenko <[email protected]>
jukkar
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.