drivers: i2c_ll_stm32: Use I2C API flags #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldts Could you also check it? |
dwagenk
approved these changes
Oct 27, 2017
superna9999
suggested changes
Oct 27, 2017
drivers/i2c/i2c_ll_stm32.c
Outdated
| if (OPERATION(current) != OPERATION(next)) { | ||
| flags = I2C_MSG_RESTART; | ||
| if (!(next->flags & I2C_MSG_RESTART)) { | ||
| return -EINVAL; |
There was a problem hiding this comment.
This seems broken for me, this means if the messages given to the API is broken, this will leave the bus in an inconsistent state
There was a problem hiding this comment.
Updated. Thanks for catching this.
drivers/i2c/i2c_ll_stm32.c
Outdated
|
|
||
| /* Stop condition is required for the last message */ | ||
| if ((num_msgs == 1) && !(current->flags & I2C_MSG_STOP)) { | ||
| return -EINVAL; |
erwango
requested changes
Oct 31, 2017
drivers/i2c/i2c_ll_stm32_v1.c
Outdated
| while (!LL_I2C_IsActiveFlag_SB(i2c)) { | ||
| ; | ||
| } | ||
| if (msg->flags & I2C_MSG_RESTART) { |
There was a problem hiding this comment.
Would you add empty lines between logical sections?
This whole function has gotten hard to read
galak
force-pushed
the
arm
branch
2 times, most recently
from
8842a2b to
d60d80f
Compare
STM32 I2C driver doesn't use the I2C API flags STOP/RESTART, instead it uses its own RESTART flag. As a result, I2C API's i2c_burst_write* funtions doesn't work. This patch makes STM32 I2C driver to use I2C API flags. Tested on: 96b_carbon, olimexino_stm32 (i2c_ll_stm32_v1) Tested on: stm32f3_disco, disco_l475_iot1 (i2c_ll_stm32_v2) Fixes: zephyrproject-rtos#4459 Signed-off-by: Yannis Damigos <[email protected]> Signed-off-by: Daniel Wagenknecht <[email protected]>
Event ISR checks if the TX/RX interrupts is enabled instead of the TXIS/RXNE interrupt status flags. Use the TXIS/RXNE interrupt status flags to check which interrupt event happened. Signed-off-by: Yannis Damigos <[email protected]> Signed-off-by: Daniel Wagenknecht <[email protected]>
|
Rebased to the latest arm branch. @superna9999 @erwango Any other comments? |
erwango
approved these changes
Nov 6, 2017
superna9999
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STM32 I2C driver doesn't use the I2C API flags STOP/RESTART,
instead it uses its own RESTART flag. As a result, I2C API's
i2c_burst_write* funtions doesn't work. This patch makes
STM32 I2C driver to use I2C API flags.
Tested on: 96b_carbon, olimexino_stm32 (i2c_ll_stm32_v1)
Tested on: stm32f3_disco, disco_l475_iot1 (i2c_ll_stm32_v2)
Fixes: #4459
Signed-off-by: Yannis Damigos [email protected]
Signed-off-by: Daniel Wagenknecht [email protected]