Logging: Add support to new cbprintf packaging features #43520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: API
nordic-krch
force-pushed
the
logging_static_packaging
branch
2 times, most recently
from
d0f14ec to
078e023
Compare
dcpleung
previously approved these changes
Mar 14, 2022
github-actions
bot
added
area: ARC
nordic-krch
force-pushed
the
logging_static_packaging
branch
from
4d2310e to
dd65b13
Compare
nordic-krch
requested review from
npitre,
carlescufi,
galak and
MaureenHelm
as code owners
nordic-krch
force-pushed
the
logging_static_packaging
branch
from
dd65b13 to
dec6aa3
Compare
nordic-krch
force-pushed
the
logging_static_packaging
branch
from
dec6aa3 to
8192c99
Compare
dcpleung
previously approved these changes
Mar 28, 2022
teburd
previously approved these changes
Mar 30, 2022
nordic-krch
force-pushed
the
logging_static_packaging
branch
from
8192c99 to
f008b8f
Compare
|
I think this needs to be rebased again. |
Adapt logging to always use static packaging. Runtime packaging is used only when configuration requires that. Static packaging significantly speeds up logging when there are string arguments. Update log_stack test to new stack usage. Signed-off-by: Krzysztof Chruscinski <[email protected]>
Size of wrong string was used. It was not seen since length was later on aligned but may lead to failures in the future. Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
force-pushed
the
logging_static_packaging
branch
from
f008b8f to
6ec78cf
Compare
|
rebased. |
dcpleung
approved these changes
Mar 30, 2022
teburd
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned logging to use static packaging whenever possible. It uses new cbprintf feature which allows to use static packaging when log message contains
%sarguments. This has two main advantages:log_bechmarktest shows 50% improvement for logging with single%sargument in the message.PR is based on #43150 with one additional commit.DNMbecause it is based on #44100.