Allow conditional config for ST7789V shields #21697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the unnamed choice for ST7789V pixel formats named so that the default value can be set in defconfig files. Signed-off-by: Jan Van Winkel <[email protected]>
Use conditional Kconfig, as introduced by PR zephyrproject-rtos#20934, for ST7789V based shields. Signed-off-by: Jan Van Winkel <[email protected]>
Enable display support for ST7789V sample by setting CONFIG_DISPLAY in prj.conf. Signed-off-by: Jan Van Winkel <[email protected]>
Update sample.yaml file for ST7789v sample to also build with st7789v_waveshare_240x240 shield. Signed-off-by: Jan Van Winkel <[email protected]>
erwango
approved these changes
Jan 6, 2020
MaureenHelm
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ST7789V shields to allow conditional configuration of the shields as introduced by PR #20934.