Added generic shield for ST7789V display controller #20570

vanwinkeljan · 2019-11-11T11:48:57Z

Added generic shield for ST7789V display controller

Fixes: #20278

zephyrbot · 2019-11-11T12:14:42Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

dbkinder · 2019-11-11T19:06:42Z

boards/shields/st7789v_generic/doc/index.rst

+
+This is a generic shield for display shields based on ST7789V display
+controller. More information about the controller can be found in
+`ST7789V Datasheet_`.


Underscore (indicating an outgoing link) is after the back-quoted text:

`ST7789V Datasheet`_.

thx for the input!

dbkinder · 2019-11-11T19:07:34Z

boards/shields/st7789v_generic/doc/index.rst

+-----------------------+---------------------------------------------+
+| Arduino Connector Pin | Function                                    |
+=======================+=============================================+
+-----------------------+---------------------------------------------+


delete this line (it creates an unnecessary blank row in the generated HTML)

dbkinder · 2019-11-11T19:08:46Z

boards/shields/st7789v_generic/doc/index.rst

+Requirements
+************
+
+This shield can only be used with a board which provides a configuration


change which to that

jfischer-no · 2019-11-12T08:32:49Z

@vanwinkeljan I do not have TL019FQV01 display but the Waveshare 1.3inch 240x240. TL019FQV01 does not seem to be so common and I think it should not be the default one. I try to find some time to add support for the Waveshare display. Also the Adafruit 1.3" 240x240 seems to be identical to one from Waveshare.

dbkinder

LGTM, with a potential table format edit.

dbkinder · 2019-11-13T21:53:18Z

boards/shields/st7789v_generic/doc/index.rst

+=======================+=============================================+
+| D8                    | ST7789V Reset                               |
+-----------------------+---------------------------------------------+
+| D9                    | ST7789V DC       (Data/Command)             |


While this is OK, if you really want to align the description part (in parentheses), you should add another column under the heading bar:

+-----------------------+---------------------------------------------+ | Arduino Connector Pin | Function | +=======================+================+============================+ | D8 | ST7789V Reset | | +-----------------------+----------------+----------------------------+ | D9 | ST7789V DC | (Data/Command) |

etc.

jfischer-no · 2019-11-13T23:44:17Z

Draft for the Waveshare 1.3inch 240x240 - https://github.com/jfischer-phytec-iot/zephyr/tree/st7789v_240x240

vanwinkeljan · 2019-11-18T07:55:56Z

@jfischer-phytec-iot do you want me to take along the waveshare support or will you push this through a separate PR?

jfischer-no · 2019-11-18T22:55:52Z

@vanwinkeljan see #20778

Added a generic display shield for boards based on the ST7789V display controller. Signed-off-by: Jan Van Winkel <[email protected]>

Use the ST7789V generic shield in ST7789V display sample Signed-off-by: Jan Van Winkel <[email protected]>

Fix style, move init function to the bottom. Signed-off-by: Johann Fischer <[email protected]>

Obtain resolution and offsets from DT. Fix style. Signed-off-by: Johann Fischer <[email protected]>

Make privat functions static, remove unused st7789v_cmd_read8(). Signed-off-by: Johann Fischer <[email protected]>

Obtain panel settings and parameters from DT. Signed-off-by: Johann Fischer <[email protected]>

Remove obsolete Kconfig options. Signed-off-by: Johann Fischer <[email protected]>

Remove obsolete display_st7789v_tl019fqv01.c Signed-off-by: Johann Fischer <[email protected]>

…rties Add TL019FQV01 parameter and settings properties. Signed-off-by: Johann Fischer <[email protected]>

Rename shield to TL019FQV01. Signed-off-by: Johann Fischer <[email protected]>

Add support for Waveshare 1.3inch IPS LCD display. Signed-off-by: Johann Fischer <[email protected]>

vanwinkeljan · 2019-11-22T07:53:30Z

@jfischer-phytec-iot I assume you tested this on Waveshare as such I removed the label blocked: HW test?

jfischer-no · 2019-11-22T08:15:03Z

@jfischer-phytec-iot I assume you tested this on Waveshare as such I removed the label blocked: HW test?

Yes, I did

jfischer-no · 2019-12-18T00:10:42Z

@erwango please review

erwango

I'm fine with the change despite conflict with #20934.
Let's see which one goes in first and which one has to rebase.

vanwinkeljan · 2019-12-18T09:57:33Z

Let's see which one goes in first and which one has to rebase.

Looks like #20934 as you request changes on this one ;)

erwango · 2019-12-18T10:01:26Z

Looks like #20934 as you request changes on this one ;)

Oups! Seems I clicked the wrong button.. approved!

MaureenHelm · 2019-12-18T22:51:41Z

samples/display/st7789v/src/main.c

@@ -121,6 +121,7 @@ void main(void)
 			*(buf + idx + 1) = (color_rgb >> 0) & 0xFFU;
 		}
 #else
+		int color = cnt % 4;


is this a stray change? it doesn't seem related to the commit message samples: display: Use ST7789V generic shield

Looks like it, but it is a bug fix for the sample in case RGB565 is not defined

Not nice but this sample (and any other controller type specific) should be removed after we merged #20580

jfischer-no · 2020-01-02T15:20:24Z

@MaureenHelm @nashif @carlescufi please revise/merge

vanwinkeljan added area: Display block: HW Test Testing on hardware required before merging labels Nov 11, 2019

vanwinkeljan requested a review from jfischer-no November 11, 2019 11:48

vanwinkeljan requested review from dbkinder and erwango as code owners November 11, 2019 11:48

vanwinkeljan mentioned this pull request Nov 11, 2019

Something is wrong when trying ST7789V sample #20278

Closed

zephyrbot added area: Boards area: Samples Samples labels Nov 11, 2019

vanwinkeljan requested a review from MaureenHelm November 11, 2019 16:36

dbkinder suggested changes Nov 11, 2019

View reviewed changes

vanwinkeljan force-pushed the st7789v_shield branch from 16da35e to 9440f36 Compare November 11, 2019 21:07

vanwinkeljan requested a review from dbkinder November 12, 2019 18:24

vanwinkeljan force-pushed the st7789v_shield branch from 9440f36 to bd5290d Compare November 13, 2019 09:59

dbkinder approved these changes Nov 13, 2019

View reviewed changes

jfischer-no mentioned this pull request Nov 14, 2019

drivers: st7789: fix offset usage #20691

Closed

jfischer-no mentioned this pull request Nov 18, 2019

drivers: display_st7789v: obtain parameters from DT, add Waveshare 1.3inch display #20778

Closed

vanwinkeljan and others added 9 commits November 21, 2019 17:55

shields: display: Added generic shield for ST7789V

b103494

Added a generic display shield for boards based on the ST7789V display controller. Signed-off-by: Jan Van Winkel <[email protected]>

samples: display: Use ST7789V generic shield

9b485a4

Use the ST7789V generic shield in ST7789V display sample Signed-off-by: Jan Van Winkel <[email protected]>

drivers: display_st7789v: fix style, move init function to the bottom

f15d60b

Fix style, move init function to the bottom. Signed-off-by: Johann Fischer <[email protected]>

drivers: display_st7789v: obtain resolution and offsets from DT

43ff895

Obtain resolution and offsets from DT. Fix style. Signed-off-by: Johann Fischer <[email protected]>

drivers: display_st7789v: make functions static, cleanup

0fe85fe

Make privat functions static, remove unused st7789v_cmd_read8(). Signed-off-by: Johann Fischer <[email protected]>

drivers: display_st7789v: obtain panel settings and parameters from DT

ada1b6f

Obtain panel settings and parameters from DT. Signed-off-by: Johann Fischer <[email protected]>

drivers: display_st7789v: remove obsolete Kconfig options

5eac3ca

Remove obsolete Kconfig options. Signed-off-by: Johann Fischer <[email protected]>

drivers: display_st7789v: remove obsolete display_st7789v_tl019fqv01.c

c1b81a0

Remove obsolete display_st7789v_tl019fqv01.c Signed-off-by: Johann Fischer <[email protected]>

shields: st7789v_generic: add TL019FQV01 parameter and settings prope…

86ae0bd

…rties Add TL019FQV01 parameter and settings properties. Signed-off-by: Johann Fischer <[email protected]>

jfischer-no added 2 commits November 21, 2019 17:55

shields: st7789v_generic: rename shield to TL019FQV01

20b3314

Rename shield to TL019FQV01. Signed-off-by: Johann Fischer <[email protected]>

shields: st7789v_generic: add support for Waveshare 1.3inch display

b327141

Add support for Waveshare 1.3inch IPS LCD display. Signed-off-by: Johann Fischer <[email protected]>

vanwinkeljan force-pushed the st7789v_shield branch from bd5290d to b327141 Compare November 21, 2019 16:58

vanwinkeljan requested a review from galak as a code owner November 21, 2019 16:58

zephyrbot added the area: Devicetree label Nov 21, 2019

jfischer-no approved these changes Nov 21, 2019

View reviewed changes

vanwinkeljan removed the block: HW Test Testing on hardware required before merging label Nov 22, 2019

vanwinkeljan added this to the v2.2.0 milestone Dec 7, 2019

erwango requested changes Dec 18, 2019

View reviewed changes

erwango approved these changes Dec 18, 2019

View reviewed changes

MaureenHelm reviewed Dec 18, 2019

View reviewed changes

nashif merged commit 7d0d845 into zephyrproject-rtos:master Jan 2, 2020

vanwinkeljan deleted the st7789v_shield branch January 4, 2020 10:41

SuperPrower mentioned this pull request Feb 6, 2020

Board nrf52832 pinetime rafacouto/zephyr#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added generic shield for ST7789V display controller #20570

Added generic shield for ST7789V display controller #20570

vanwinkeljan commented Nov 11, 2019

zephyrbot commented Nov 11, 2019 •

edited

Loading

dbkinder Nov 11, 2019

vanwinkeljan Nov 11, 2019

dbkinder Nov 11, 2019

dbkinder Nov 11, 2019

jfischer-no commented Nov 12, 2019

dbkinder left a comment

dbkinder Nov 13, 2019

jfischer-no commented Nov 13, 2019 •

edited

Loading

vanwinkeljan commented Nov 18, 2019

jfischer-no commented Nov 18, 2019

vanwinkeljan commented Nov 22, 2019

jfischer-no commented Nov 22, 2019

jfischer-no commented Dec 18, 2019

erwango left a comment

vanwinkeljan commented Dec 18, 2019

erwango commented Dec 18, 2019

MaureenHelm Dec 18, 2019

vanwinkeljan Dec 19, 2019

jfischer-no Dec 19, 2019

jfischer-no commented Jan 2, 2020

Added generic shield for ST7789V display controller #20570

Added generic shield for ST7789V display controller #20570

Conversation

vanwinkeljan commented Nov 11, 2019

zephyrbot commented Nov 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfischer-no commented Nov 12, 2019

dbkinder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfischer-no commented Nov 13, 2019 • edited Loading

vanwinkeljan commented Nov 18, 2019

jfischer-no commented Nov 18, 2019

vanwinkeljan commented Nov 22, 2019

jfischer-no commented Nov 22, 2019

jfischer-no commented Dec 18, 2019

erwango left a comment

Choose a reason for hiding this comment

vanwinkeljan commented Dec 18, 2019

erwango commented Dec 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfischer-no commented Jan 2, 2020

zephyrbot commented Nov 11, 2019 •

edited

Loading

jfischer-no commented Nov 13, 2019 •

edited

Loading