[Backport v1.14-branch] usb: usb_dfu: do not set bwPollTimeout dynamically #15966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backporting[bot]](https://avatars.githubusercontent.com/in/15821?s=60&v=4){kind=small}
Partially revert commit ea177e7 ("usb: dfu: set bwPollTimeout dynamically") Introduced fix does not work proper because there is no way to be sure that a control stage had success before start erase process. Instead IMG_ERASE_PROGRESSIVELY configuration should be used if the erase of the flash takes longer time. resolves: #15497 Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
approved these changes
May 7, 2019
|
We need to think about this a bit more since the fix removes a Kconfig option. If some app happened to be utilizing that option we would end up possibly breaking behavior. |
nashif
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15747.
Fixes #15497