[Backport v1.14-branch] net/ip/dhcpv4: Set source IP address for DHCP renewal requests #15534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backporting[bot]](https://avatars.githubusercontent.com/in/15821?s=60&v=4){kind=small}
The source address in unicast DHCPv4 Request packets was found out to be all zeros address 0.0.0.0. This address is only acceptable if the destination is a multicast one, where the host in question is acquiring a DHCP address lease. This is true for the DHCP Discover and the initial DHCP Request message from the client towards the server. As subsequent DHCP Request renewal messages are sent as unicast to the server, the server will drop such packets. Fix this issue by explicitely specifying what source IP address is to be used, if none is specified, the all zeros address 0.0.0.0 is used in multicast addresses. The source address in the other unicast cases is identical to the 'ciaddr' in the DHCP message. Signed-off-by: Patrik Flykt <[email protected]>
backporting
bot
requested review from
jukkar,
pfalcon and
tbursztyka
as code owners
galak
approved these changes
Apr 17, 2019
pfalcon
approved these changes
Apr 23, 2019
jukkar
approved these changes
Apr 23, 2019
|
@jukkar do we have a bug that this PR fixes? |
tbursztyka
approved these changes
May 1, 2019
|
@nashif there is no bug report for this but I feel that it fixes something that would be needed in 1.14 |
|
you need to open a bug. |
|
@pfl Could you create a bug report for this already fixed issue so that we could merge this to 1.14? |
|
Disqualified myself from reviewing my own fixes. |
Bug is #16012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15179.
Fixes #16012