Fix OpenAMP building with newlib #14203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix the issue in #8104 |
|
Found the following issues, please fix and resubmit: License issuesIn most cases you do not need to do anything here, especially if the files
|
Pull in libmetal SHA 59a10acbb0bb684c1a75488f11878cb984170c81 to get some build fixes related to newlib. Signed-off-by: Kumar Gala <[email protected]>
If we enable newlib we run into an issue with fcntl.h and the openamp proxy support. We don't utilize the proxy support so just disable it by default. Signed-off-by: Kumar Gala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #14203 +/- ##
=======================================
Coverage 52.68% 52.68%
=======================================
Files 307 307
Lines 45473 45473
Branches 10530 10530
=======================================
Hits 23956 23956
Misses 16640 16640
Partials 4877 4877Continue to review full report at Codecov.
|
carlescufi
approved these changes
Mar 8, 2019
MaureenHelm
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 different issues we run into when trying to build with newlib. One was with C11 Atomic's and was a bug in libmetal, we got that fixed in upstream libmetal and updated to the fixed version. The second issue is with fcntl which we just need to not enable WITH_PROXY support to fix.