shell: Allocate proper amount of history slab memory #13048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13048 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 313 313
Lines 46436 46436
Branches 10710 10710
=======================================
Hits 22585 22585
Misses 19395 19395
Partials 4456 4456
Continue to review full report at Codecov.
|
andrewboie
approved these changes
Feb 5, 2019
jakub-uC
approved these changes
Feb 5, 2019
nordic-krch
approved these changes
Feb 5, 2019
|
i will improve history handling in the future in terms of ram used as current solution is not optimal but let's get that in so that goes to 1.14. |
carlescufi
approved these changes
Feb 5, 2019
agross-oss
force-pushed
the
shell-alloc-fix
branch
from
b2db7d1 to
237b817
Compare
|
reduced number of buffers by 1 to offset memory cost of increasing the overall per buffer size. |
agross-oss
force-pushed
the
shell-alloc-fix
branch
from
237b817 to
09d2815
Compare
|
Found a nice issue with k_mem_slab allowing for non-aligned block size. So added in ROUND_UP() to fix that. |
This patch increases the amount of slab memory per item for the shell history to match the maximum command input buffer size plus the accounting information for the dnode list item. Signed-off-by: Andy Gross <[email protected]>
agross-oss
force-pushed
the
shell-alloc-fix
branch
from
09d2815 to
0d8a8aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch increases the amount of slab memory per item for the shell
history to match the maximum command input buffer size plus the
accounting information for the dnode list item.
Signed-off-by: Andy Gross [email protected]