Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 338107] Division or modulo by zero in subsys/shell/backends/shell_uart.c #66800

Closed
zephyrbot opened this issue Dec 21, 2023 · 0 comments · Fixed by #75905
Closed

[Coverity CID: 338107] Division or modulo by zero in subsys/shell/backends/shell_uart.c #66800

zephyrbot opened this issue Dec 21, 2023 · 0 comments · Fixed by #75905
Assignees
@jakub-uC
Labels
area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/master/subsys/shell/backends/shell_uart.c

Category: Integer handling issues
Function: async_init
Component: Shell
CID: 338107

Details:

https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/shell/backends/shell_uart.c#L248

Please fix or provide comments in coverity using the link:

https://scan9.scan.coverity.com/reports.htm#v29271/p12996.

For more information about the violation, check the Coverity Reference. (CWE-369)

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the MAINTAINERS file.
@zephyrbot zephyrbot added area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Dec 21, 2023
ceolin pushed a commit to ceolin/zephyr that referenced this issue Jul 15, 2024
serial: uart_async_rx: Avoid possible division by zero
cf8ef7a 
Ensures that config->but_cnt is not zero.

Fixes zephyrproject-rtos#66800
CID #338107

Signed-off-by: Flavio Ceolin <[email protected]>
@ceolin ceolin mentioned this issue Jul 15, 2024
Merged
@nashif nashif closed this as completed in 5822267 Jul 27, 2024
zephyrbot pushed a commit that referenced this issue Jul 27, 2024
@github-actions
serial: uart_async_rx: Avoid possible division by zero
d921089 
Ensures that config->but_cnt is not zero.

Fixes #66800
CID #338107

Signed-off-by: Flavio Ceolin <[email protected]>
(cherry picked from commit 5822267)
@nashif nashif mentioned this issue Aug 6, 2024
Merged
Chenhongren pushed a commit to Chenhongren/zephyr that referenced this issue Aug 26, 2024
serial: uart_async_rx: Avoid possible division by zero
535d9ca 
Ensures that config->but_cnt is not zero.

Fixes zephyrproject-rtos#66800
CID #338107

(cherry picked from commit 5822267)

Original-Signed-off-by: Flavio Ceolin <[email protected]>
GitOrigin-RevId: 5822267
Change-Id: Idde04065f10393f57ad02491b4de6d54b893eb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5745532
Reviewed-by: Fabio Baltieri <[email protected]>
Commit-Queue: Fabio Baltieri <[email protected]>
Tested-by: ChromeOS Prod (Robot) <[email protected]>
nashif pushed a commit that referenced this issue Sep 17, 2024
@nashif
serial: uart_async_rx: Avoid possible division by zero
062d4d5 
Ensures that config->but_cnt is not zero.

Fixes #66800
CID #338107

Signed-off-by: Flavio Ceolin <[email protected]>
(cherry picked from commit 5822267)
mariucker pushed a commit to mariucker/zephyr that referenced this issue Dec 12, 2024
@mariucker
serial: uart_async_rx: Avoid possible division by zero
48babc2 
Ensures that config->but_cnt is not zero.

Fixes zephyrproject-rtos#66800
CID #338107

Signed-off-by: Flavio Ceolin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakub-uC jakub-uC

Labels
area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

serial: uart_async_rx: Avoid possible division by zero ceolin/zephyr
2 participants
@zephyrbot @jakub-uC