Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen_syscall_header_py is being run at the wrong time #5186

Closed
andrewboie opened this issue Nov 28, 2017 · 1 comment · Fixed by #5203
Closed

gen_syscall_header_py is being run at the wrong time #5186

andrewboie opened this issue Nov 28, 2017 · 1 comment · Fixed by #5203
Assignees
@SebastianBoe
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@andrewboie
Copy link
Contributor

gen_syscall_header.py is being run at cmake time, not at build time.
There seems to be an assumption that this action has no dependencies. This is not true. The script itself is a dependency.
The build system needs to re-run this script, when it builds the kernel, if the script itself changes. This used to work but broke with the new build system.
@andrewboie andrewboie added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels Nov 28, 2017
@andrewboie
Copy link
Contributor Author

Another problem: if the script fails to run, the build doesn't break.

SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Nov 29, 2017
@SebastianBoe
Give up on using the preprocessor to solve
4c1ebf6 
zephyrproject-rtos#5186

Signed-off-by: Sebastian Bøe <[email protected]>
SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Nov 29, 2017
@SebastianBoe
cmake: Move syscall_macros.h generation into the build stage
d83f377 
This fixes zephyrproject-rtos#5186

The script that generates syscall_macros.h is moved from Configuration
time to build time. This allows us to express to the build system that
syscall_macros.h depends on the script that generates it.

Signed-off-by: Sebastian Bøe <[email protected]>
@SebastianBoe SebastianBoe mentioned this issue Nov 29, 2017
Merged
nashif pushed a commit that referenced this issue Nov 30, 2017
@SebastianBoe
cmake: Move syscall_macros.h generation into the build stage
2ead15d 
This fixes #5186

The script that generates syscall_macros.h is moved from Configuration
time to build time. This allows us to express to the build system that
syscall_macros.h depends on the script that generates it.

Signed-off-by: Sebastian Bøe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebastianBoe SebastianBoe

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Move syscall_macros.h generation into the build stage SebastianBoe/zephyr
2 participants
@SebastianBoe @andrewboie