Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee802154_uart_pipe.c: warning: return from incompatible pointer type #4165

Closed
pfalcon opened this issue Oct 3, 2017 · 3 comments
Closed
Assignees

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Oct 3, 2017

Building echo_client with make "CONF_FILE=prj_qemu_802154.conf", there's a warning:

  CC      drivers/ieee802154/ieee802154_uart_pipe.o
/mnt/hdd/projects-3rdparty/Embedded/Zephyr/zephyr/drivers/ieee802154/ieee802154_uart_pipe.c: In function ‘upipe_rx’:
/mnt/hdd/projects-3rdparty/Embedded/Zephyr/zephyr/drivers/ieee802154/ieee802154_uart_pipe.c:96:9: warning: return from incompatible pointer type [-Wincompatible-pointer-types]
  return pkt;
         ^~~

I quickly compared that with e.g. slip.c, and saw processing in rx callback is quite different there. @tbursztyka , can you please see if it requires just a cast, or more things bitrotted there?

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 3, 2017

To see this warning (instead of bunch of errors), #4166 should be applied first.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 3, 2017

@priyankaNXP: FYI

@tbursztyka
Copy link
Collaborator

Good catch, it's a net_nbuf/net_pkt introduced error (commit id db11fcd). So instead of pkt it should return buf as before. Will fix it asap

tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue Oct 4, 2017
A wrong name replacement was applied during commit
db11fcd

Fixes issue zephyrproject-rtos#4165

Signed-off-by: Tomasz Bursztyka <[email protected]>
jukkar pushed a commit that referenced this issue Oct 4, 2017
A wrong name replacement was applied during commit
db11fcd

Fixes issue #4165

Signed-off-by: Tomasz Bursztyka <[email protected]>
@pfalcon pfalcon closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants