Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build warning: [-Wpointer-bool-conversion] with LLVM/icx (samples/bluetooth/mesh_demo) #3984

Closed
zephyrbot opened this issue Aug 18, 2017 · 0 comments
Closed

Build warning: [-Wpointer-bool-conversion] with LLVM/icx (samples/bluetooth/mesh_demo) #3984

zephyrbot opened this issue Aug 18, 2017 · 0 comments
Assignees
@jhedberg
Labels
area: Bluetooth area: Samples Samples bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone
v1.10.0

Comments

@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 18, 2017 •
edited
Loading

Reported by ashish sinha:

Test case with build warnings raised from LLVM/icx:
samples/bluetooth/mesh_demo


zephyr/subsys/bluetooth/host/mesh/transport.c:982:30: warning: 
      address of 'net_rx->ctx' will always evaluate to 'true'
      [-Wpointer-bool-conversion]
        if (!sdu_len_is_ok(&net_rx->ctx, seg_n)) {
             ~~~~~~~~~~~~~  ~~~~~~~~^~~
1 warning generated.
  CC      subsys/bluetooth/host/mesh/crypto.o
  CC      subsys/bluetooth/host/mesh/access.o
zephyr/subsys/bluetooth/host/mesh/access.c:35:3: warning: 
      duplicate 'const' declaration specifier [-Wduplicate-decl-specifier]
} const model_init[] = {
  ^
1 warning generated.

how-to-reproduce:

source zephyr-env.sh
export ZEPHYR_GCC_VARIANT=issm
cd samples/bluetooth/mesh_demo
make pristine
make BOARD=quark_se_c1000_devboard CC=icx

(Imported from Jira ZEP-2554)
@zephyrbot zephyrbot added priority: low Low impact/importance bug area: Samples Samples area: Bluetooth bug The issue is a bug, or the PR is fixing a bug labels Sep 23, 2017
@zephyrbot zephyrbot added this to the v1.10.0 milestone Sep 23, 2017
@zephyrbot zephyrbot mentioned this issue Sep 23, 2017
Closed
jhedberg pushed a commit to jhedberg/zephyr that referenced this issue Sep 26, 2017
Bluetooth: Mesh: Fix SDU length check
71a5b67 
The code was passing the wrong first parameter to the sdu_len_is_ok()
function.

Fixes zephyrproject-rtos#3985
Fixes zephyrproject-rtos#3984

Signed-off-by: Johan Hedberg <[email protected]>
jhedberg pushed a commit to jhedberg/zephyr that referenced this issue Oct 19, 2017
Bluetooth: Mesh: Fix SDU length check
cbc2e91 
The code was passing the wrong first parameter to the sdu_len_is_ok()
function.

Fixes zephyrproject-rtos#3985
Fixes zephyrproject-rtos#3984

Signed-off-by: Johan Hedberg <[email protected]>
nashif pushed a commit that referenced this issue Oct 19, 2017
Bluetooth: Mesh: Fix SDU length check
971080c 
The code was passing the wrong first parameter to the sdu_len_is_ok()
function.

Fixes #3985
Fixes #3984

Signed-off-by: Johan Hedberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhedberg jhedberg

Labels
area: Bluetooth area: Samples Samples bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
2 participants
@jhedberg @zephyrbot