Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make qemu" may not regenerate .config after changes to prj.conf #1522

Closed
pfalcon opened this issue Sep 15, 2017 · 5 comments
Closed

"make qemu" may not regenerate .config after changes to prj.conf #1522

pfalcon opened this issue Sep 15, 2017 · 5 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Sep 15, 2017

I noticed that "make qemu", which was deprecated, but is still there, may not propagate changes if prj.conf was updated (i.e. it would not cause .config to be updated and/or an app to be rebuilt). Let's either make it behave the same as "make run", or remove completely.

@nashif
Copy link
Member

nashif commented Sep 15, 2017

make qemu does exist anymore, what makes you say it is still available?

@nashif nashif removed the net label Sep 15, 2017
@nashif nashif added the bug The issue is a bug, or the PR is fixing a bug label Sep 15, 2017
@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 15, 2017

The fact that I very well remember when Zephyr had it, and so still occasionally use it, and it "works" (runs QEMU as expected). So, let's either kill it completely (so for example "make qemu" printed "Error: use 'make run' instead"), or let's maintain it in a deprecated shape, so at least it didn't do harm to folks for whom it's being maintained.

@nashif
Copy link
Member

nashif commented Sep 16, 2017

'make qemu' does not work anymore, it was removed after being deprecated for a while. You should be using 'make run' now.

@dbkinder dbkinder changed the title "make qemu" may not regenate .config after changes to prj.conf "make qemu" may not regenerate .config after changes to prj.conf Sep 16, 2017
@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 17, 2017

'make qemu' does not work anymore

It does for me:

$ cd samples/net/echo_server
#  don't trust Zephyr's *clean
$ rm -rf outdir
$ make
$ make qemu
make[1]: Entering directory '/mnt/hdd/projects-3rdparty/Embedded/Zephyr/zephyr'
make[2]: Entering directory '/mnt/hdd/projects-3rdparty/Embedded/Zephyr/zephyr/samples/net/echo_server/outdir/qemu_x86'
  CHK     include/generated/generated_dts_board.conf
  Using /mnt/hdd/projects-3rdparty/Embedded/Zephyr/zephyr as source for kernel
  GEN     ./Makefile
  CHK     include/generated/version.h
  CHK     include/generated/generated_dts_board.h
  CHK     misc/generated/configs.c
  CHK     include/generated/offsets.h
To exit from QEMU enter: 'CTRL+a, x'
[QEMU] CPU: qemu32
qemu-system-i386: warning: Unknown firmware file in legacy mode: genroms/multiboot.bin

shell> [net/app] [INF] net_app_init: Initializing network
[net/app] [INF] setup_ipv4: IPv4 address: 192.0.2.1
[net/app] [INF] ipv6_event_handler: IPv6 address: fe80::200:5eff:fe00:53e5
[net/app] [INF] ipv6_event_handler: IPv6 address: fe80::200:5eff:fe00:53e5

So, if someone has an older script which uses "make qemu" or reads older instructions using it, they may be affected by an issue in the subj.

@nashif
Copy link
Member

nashif commented Sep 18, 2017

ok, we forgot a target in 1 spot, scripts/Makefile.qemu

nashif added a commit to nashif/zephyr that referenced this issue Sep 19, 2017
nashif added a commit that referenced this issue Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

3 participants