net/ip: fix input packet filtering criteria

The "is this packet for us?" filter in net_ipv4_input() has a minor logic error which fails to discard many packets which are.. not for us. Fixes: #14647 Signed-off-by: Charles E. Youse <[email protected]>
zephyrproject-rtos · Mar 19, 2019 · e82769c · e82769c
1 parent 3a8767c
commit e82769c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/subsys/net/ip/ipv4.c b/subsys/net/ip/ipv4.c
@@ -208,8 +208,8 @@ enum net_verdict net_ipv4_input(struct net_pkt *pkt)
 		goto drop;
 	}
 
-	if (!net_ipv4_is_my_addr(&hdr->dst) &&
-	    !net_ipv4_is_addr_mcast(&hdr->dst) &&
+	if ((!net_ipv4_is_my_addr(&hdr->dst) &&
+	    !net_ipv4_is_addr_mcast(&hdr->dst)) ||
 	    ((hdr->proto == IPPROTO_UDP &&
 	      net_ipv4_addr_cmp(&hdr->dst, net_ipv4_broadcast_address()) &&
 	      !IS_ENABLED(CONFIG_NET_DHCPV4)) ||