#914 - mysqli constructor

.github/workflows/build-windows.yml

@@ -51,7 +51,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
-          extensions: mbstring, fileinfo, gmp, sqlite, pdo_sqlite, psr, zip
+          extensions: mbstring, fileinfo, gmp, sqlite, pdo_sqlite, psr, zip, mysqli
           coverage: none
           # variables_order: https://github.com/zephir-lang/zephir/pull/1537
           # enable_dl: https://github.com/zephir-lang/zephir/pull/1654

Library/StaticCall.php

@@ -78,7 +78,7 @@ public function compile(Expression $expr, CompilationContext $compilationContext
             }
         }
 
-        /*
+        /**
          * Include fcall header
          */
         $compilationContext->headersManager->add('kernel/fcall');
@@ -127,10 +127,11 @@ public function compile(Expression $expr, CompilationContext $compilationContext
             }
         }
 
-        /*
+        /**
          * Check if the class implements the method
          */
         if (!$dynamicMethod && !$dynamicClass) {
+            // TODO: Consider to check instance of ClassDefinitionRuntime and throw another error, telling that class was not found.
             if (!$classDefinition->hasMethod($methodName)) {
                 $possibleMethod = $classDefinition->getPossibleMethodName($methodName);
                 if ($possibleMethod) {
@@ -153,7 +154,7 @@ public function compile(Expression $expr, CompilationContext $compilationContext
 
                 if (!$classDefinition->hasMethod('__callStatic')) {
                     if ($method instanceof ClassMethod && !$method->isBundled()) {
-                        /*
+                        /**
                          * Try to produce an exception if method is called with a wrong number of parameters
                          */
                         if (isset($expression['parameters'])) {

docker-compose.yml

@@ -1,10 +1,5 @@
 # For local development only.
 
-# First development steps after start containers:
-#     - .ci/install-zephir-parser.sh
-#     - php zephir stubs
-#     - cd ext/ && ./install
-
 version: '3'
 
 services:

docker/7.4/Dockerfile

@@ -15,7 +15,7 @@ RUN apt update -y && apt install -y \
     libzip-dev && \
     pecl install psr
 
-RUN docker-php-ext-install zip gmp intl && \
+RUN docker-php-ext-install zip gmp intl mysqli && \
     docker-php-ext-enable psr
 
 # Install Zephir parser

docker/8.0/Dockerfile

@@ -15,7 +15,7 @@ RUN apt update -y && apt install -y \
     libzip-dev && \
     pecl install psr
 
-RUN docker-php-ext-install zip gmp intl && \
+RUN docker-php-ext-install zip gmp intl mysqli && \
     docker-php-ext-enable psr
 
 # Install Zephir parser

stub/issue914.zep

@@ -0,0 +1,9 @@
+namespace Stub;
+
+class Issue914 extends \mysqli
+{
+    public function __construct()
+    {
+        parent::__construct();
+    }
+}

tests/Extension/Issue914Test.php

@@ -0,0 +1,27 @@
+<?php
+
+/**
+ * This file is part of the Zephir.
+ *
+ * (c) Phalcon Team <[email protected]>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Extension;
+
+use PHPUnit\Framework\TestCase;
+use Stub\Issue914;
+
+final class Issue914Test extends TestCase
+{
+    public function testIssue914(): void
+    {
+        $test = new Issue914();
+
+        $this->assertInstanceOf(\mysqli::class, $test);
+    }
+}