Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2186 - Fix null strict check #2197

Merged
merged 7 commits into from
Apr 8, 2021
Merged

#2186 - Fix null strict check #2197

merged 7 commits into from
Apr 8, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Apr 7, 2021 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson added the bug label Apr 7, 2021
@Jeckerson Jeckerson requested a review from AlexNDRmac April 7, 2021 21:45
@Jeckerson Jeckerson self-assigned this Apr 7, 2021
@Jeckerson Jeckerson added this to the 0.13.2 milestone Apr 7, 2021
@Jeckerson Jeckerson linked an issue Apr 7, 2021 that may be closed by this pull request
Wrong macro on nullable value #2186
Closed
@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #2197 (abdf616) into development (295f9bb) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head abdf616 differs from pull request most recent head ae55884. Consider uploading reports for the commit ae55884 to get more accurate results

@@              Coverage Diff              @@
##             development   #2197   +/-   ##
=============================================
  Coverage           7.69%   7.69%           
+ Complexity          8685    8683    -2     
=============================================
  Files                355     355           
  Lines              21977   21973    -4     
=============================================
  Hits                1691    1691           
+ Misses             20286   20282    -4

@Jeckerson Jeckerson merged commit 006b504 into development Apr 8, 2021
@Jeckerson Jeckerson deleted the #2186-null-strict-check branch April 8, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNDRmac AlexNDRmac AlexNDRmac approved these changes

Assignees

@Jeckerson Jeckerson

Labels
bug
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.

Wrong macro on nullable value
2 participants
@Jeckerson @AlexNDRmac