Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#812 - Fix uint cast to abs in function params #2192

Merged
merged 6 commits into from
Apr 8, 2021
Merged

#812 - Fix uint cast to abs in function params #2192

merged 6 commits into from
Apr 8, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Apr 4, 2021 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson added the bug label Apr 4, 2021
@Jeckerson Jeckerson added this to the 0.13.x milestone Apr 4, 2021
@Jeckerson Jeckerson self-assigned this Apr 4, 2021
@Jeckerson Jeckerson linked an issue Apr 6, 2021 that may be closed by this pull request
Input method argument with type uint not coverted to uint. #812
Closed
@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #2192 (656ed4d) into development (55e8c66) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##             development   #2192      +/-   ##
================================================
- Coverage           7.69%   7.69%   -0.01%     
- Complexity          8683    8685       +2     
================================================
  Files                355     355              
  Lines              21973   21977       +4     
================================================
  Hits                1691    1691              
- Misses             20282   20286       +4

@Jeckerson Jeckerson marked this pull request as ready for review April 7, 2021 20:20
@Jeckerson Jeckerson requested a review from AlexNDRmac April 7, 2021 20:20
@Jeckerson Jeckerson modified the milestones: 0.13.x, 0.13.2 Apr 7, 2021
@AlexNDRmac AlexNDRmac merged commit 295f9bb into development Apr 8, 2021
@AlexNDRmac AlexNDRmac deleted the #812-fix-uint-abs branch April 8, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNDRmac AlexNDRmac AlexNDRmac approved these changes

Assignees

@Jeckerson Jeckerson

Labels
bug
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.

Input method argument with type uint not coverted to uint.
2 participants
@Jeckerson @AlexNDRmac