stub supports void type return value #2124
Merged
+183
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2124 +/- ##
==============================================
Coverage 36.72% 36.72%
- Complexity 8310 8312 +2
==============================================
Files 568 568
Lines 46345 46347 +2
==============================================
+ Hits 17018 17020 +2
Misses 29327 29327 |
AlexNDRmac
requested changes
Nov 26, 2020
|
https://github.com/phalcon/zephir/blob/development/Library/Stubs/Generator.php#L304-L309 |
No, It should be removed with small refactoring later. Thank you. |
|
okay. Thank you. |
AlexNDRmac
approved these changes
Nov 28, 2020
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Zephir stubs shouldn't add 'void' return type hint #1977
In raising this pull request, I confirm the following:
Small description of change:
I added it because I didn't consider the case where the return value is void type.
Thanks