Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix | 1990 return type annotation #2004

Merged
merged 22 commits into from
Nov 9, 2019
Merged

Bugfix | 1990 return type annotation #2004

merged 22 commits into from
Nov 9, 2019

Conversation

AlexNDRmac
Copy link
Member

@AlexNDRmac AlexNDRmac commented Nov 9, 2019 •
edited by sergeyklay
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

  • added support for php-compatible return types for stubs generation
  • small code refactoring
  • added sharness tests
  • added Unit tests

@AlexNDRmac
Ignore prove cache
57c0fb6
@AlexNDRmac
add comment about description in return types
a632d1c
@AlexNDRmac
add type compatibility resolving for integer and float
9a42ed0
@AlexNDRmac
add boolean type resolving
ad411ad
@AlexNDRmac
add array type resolving
a3a24e8
@AlexNDRmac
add other types resolving
107f9d4
@AlexNDRmac
Refactor type resolving for simple types
2b85dc0
@AlexNDRmac
do not use static access for types
dd6a167
@AlexNDRmac
amend missed include
a2f04da
@AlexNDRmac
improve tests flexibility
588dfc9
@AlexNDRmac
Improve code readability, add object definition for test
3b0a3c7
@AlexNDRmac
support objects types resolving
ff63110
@AlexNDRmac
changed method name, fixed test
ad3f41d
@AlexNDRmac
print phpcs tools version into travis report
f2468a7
@AlexNDRmac
fix method name
b69af10
@AlexNDRmac
move ignore rule for prove to proper gitignore
df53afa
@AlexNDRmac
remove useless and painful comma
8b6d370
@AlexNDRmac
improve readability, add test case
de7cbdc
@AlexNDRmac
add sharness tests for stubs
4b7fc9a
@AlexNDRmac
fix variables declaration for zep test
16b6321
@AlexNDRmac
remove nullable return type from test
547b06f
@AlexNDRmac
Apply SRP to Types Class
055a6a3
@AlexNDRmac AlexNDRmac requested a review from sergeyklay November 9, 2019 11:14
@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #2004 into development will increase coverage by 0.24%.
The diff coverage is 99.01%.

@@                Coverage Diff                @@
##             development    #2004      +/-   ##
=================================================
+ Coverage          34.32%   34.56%   +0.24%     
- Complexity          8162     8209      +47     
=================================================
  Files                561      562       +1     
  Lines              45196    45303     +107     
=================================================
+ Hits               15514    15661     +147     
+ Misses             29682    29642      -40

@sergeyklay sergeyklay merged commit 983f994 into development Nov 9, 2019
@sergeyklay
Copy link
Contributor

Thank you

@sergeyklay sergeyklay deleted the bugfix/1990-return-type-annotation branch November 9, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexNDRmac @sergeyklay