-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1400 #1819
Fix #1400 #1819
Conversation
@dreamsxin This code seems to be incompatible with the Windows compiler. At least we have the following:
I think this can be made more portable. Could you take a look? |
PHP 5.x will be supported today. |
@sergeyklay All right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thank you |
In raising this pull request, I confirm the following:
Small description of change:
Thanks