Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do *not* remove compiled file during zephir install #2175

Closed
Jeckerson opened this issue Mar 27, 2021 · 0 comments · Fixed by #2182
Closed

Do *not* remove compiled file during zephir install #2175

Jeckerson opened this issue Mar 27, 2021 · 0 comments · Fixed by #2182
Assignees
@Jeckerson
Labels
bug
Milestone
0.13.1

Comments

@Jeckerson
Copy link
Member

zephir/Library/Compiler.php

Line 1006 in d4d9982

if (file_exists("{$currentDir}/ext/modules/{$namespace}.so")) {

Move file_exists() check to compile
@Jeckerson Jeckerson added the bug label Mar 27, 2021
@Jeckerson Jeckerson added this to the 0.13.x milestone Mar 27, 2021
@Jeckerson Jeckerson self-assigned this Mar 28, 2021
Jeckerson added a commit that referenced this issue Mar 30, 2021
@Jeckerson
#2175 - Move files check from install() to compile()
88106f3
Jeckerson added a commit that referenced this issue Mar 30, 2021
@Jeckerson
#2175 - Update CHANGELOG.md
45498d1
@Jeckerson Jeckerson mentioned this issue Mar 30, 2021
Merged
3 tasks
@Jeckerson Jeckerson linked a pull request Mar 30, 2021 that will close this issue
#2175 - Fix install command #2182
Merged
3 tasks
@Jeckerson Jeckerson modified the milestones: 0.13.x, 0.13.1 Mar 30, 2021
Jeckerson added a commit that referenced this issue Mar 31, 2021
@Jeckerson
Merge pull request #2182 from zephir-lang/#2175-fix-install-command
54830d3 
#2175 - Fix install command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
bug
Projects
None yet
Milestone
0.13.1
Development

Successfully merging a pull request may close this issue.

#2175 - Fix install command zephir-lang/zephir
1 participant
@Jeckerson