Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property visibility is broken #2057

Closed
Jurigag opened this issue Feb 4, 2020 · 0 comments
Closed

Property visibility is broken #2057

Jurigag opened this issue Feb 4, 2020 · 0 comments
Assignees
@sergeyklay
Labels
bug

Comments

@Jurigag
Copy link
Contributor

Jurigag commented Feb 4, 2020 •
edited by sergeyklay
Loading

Just check failing tests here - #2056, #2078

Zephir ignores property visibility, there is no error thrown when setting private/protected properties in scope that shouldn't do it.

Also __set is ignored as well in that case.
This was referenced Feb 4, 2020
Open
Closed
@sergeyklay sergeyklay self-assigned this Mar 26, 2020
sergeyklay added a commit that referenced this issue Apr 16, 2020
@sergeyklay
Added tests for #2057 (part I)
27b7c0d
sergeyklay added a commit that referenced this issue Apr 16, 2020
@sergeyklay
Amended tests for #2057 (part II)
e42e591
@sergeyklay sergeyklay mentioned this issue Apr 16, 2020
Merged
3 tasks
sergeyklay added a commit that referenced this issue Apr 23, 2020
@sergeyklay
Amended tests for #2057 (part III)
69f56a3
sergeyklay added a commit that referenced this issue Apr 23, 2020
@sergeyklay
Amended tests for #2057 (part III)
8da899b
@sergeyklay sergeyklay added the bug label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergeyklay @Jurigag