fix: trigger after persist callbacks for entities scheduled for insert #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/after-persist-and-schedule-for-insert
branch
from
f55a394 to
f66a30b
Compare
nikophil
commented
Feb 17, 2025
| * @internal | ||
| * @var Parameters|null | ||
| */ | ||
| protected ?array $normalizedParameters = null; |
There was a problem hiding this comment.
this is not needed anymore, because we're scheduling entities for insert from an "after instantiate" callback, so we can pass the attributes from there
nikophil
force-pushed
the
fix/after-persist-and-schedule-for-insert
branch
from
f66a30b to
705f4e2
Compare
kbond
approved these changes
Feb 23, 2025
nikophil
added a commit
to nikophil/foundry
that referenced
this pull request
Feb 24, 2025
* 2.3.x: changelog: update [skip ci] bot: fix cs [skip ci] fix: actually disable persistence cascade (zenstruck#817) fix: trigger after persist callbacks for entities scheduled for insert (zenstruck#822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we're now "scheduling for insert" some entities, and not directly saving them, we should take care of their after persist callbacks differently. The proposal of this PR is to give this responsibility to
PersistenceManagerfixes #821