This repository was archived by the owner on Jan 29, 2020. It is now read-only.
drop request's scriptFile checks in favour of getlastmod() built-in function #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a little refactoring
Note:
I would have liked to test different
getLastModified()
return values, but: 1) I cannot find a way to mock builtin php functions return values (getlastmod, filemetime) without using pecl extensions. 2) I could mock the return value ofgetLastModified
using an inline class, but at the expense of changing the visibility of the method to "protected".