This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Add support for session cookie domain, secure, and http-only flags #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds assertions against the domain, secure, and http-only flags of the generated `Set-Cookie`, based on the current INI values.
weierophinney
force-pushed
the
feature/2-full-session-cookie-attributes
branch
from
a9ca579 to
7aad764
Compare
geerteltink
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds off of smalot#2, adding assertions to an existing test to validate that the appropriate flags for the session cookie domain, secure status, and http-only status are set appropriately.
It adds support for the following INI flags/values:
session.cookie_domainsession.cookie_httponlysession.cookie_secureFixes #30