This repository was archived by the owner on Jan 29, 2020. It is now read-only.
fix unsent cookie issue #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
approved these changes
Apr 26, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
|
Thanks, @pine3ree! |
pine3ree
pushed a commit
to pine3ree/zend-expressive-session-ext
that referenced
this pull request
May 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weierophinney
Does this make sense to You?
The
$cookieinternal property gets the value from the requestsession_name()cookie, if any.If no request cookie value is found it gets a freshly generated session id value
In any case
$cookiehas the value for the session id and its used to start the sessionWhen returning the response we must include a set-cookie header with the same value (and name equal to session_name())
If the session is regenerated a new session id value is created and that value (saved into $cookie) must be passed into the response cookie header, instead of the old session id.
kind regards,
#10