This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Support for FCM (#20) #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kleisauke
commented
Sep 12, 2016
•
kleisauke
commented
- Change GCM end-point to FCM
- Make Travis happy
- Test PHP 7.0 (Update .travis.yml for test php 7.0 #22)
- Add new parameters from FCM docs (New parameter added from GCM docs #21) (https://firebase.google.com/docs/cloud-messaging/http-server-ref)
- Some PHP doc fixes
- Update PHPUnit
- Fix Travis for PHP 7 (Test against PHP 7.0 and 7.1 #9)
- Change GCM end-point to FCM - Make Travis happy - Test PHP 7.0 (zendframework#22) - Add new parameters from FCM docs (zendframework#21) - Some PHP doc fixes
PHP 7 throws `TypeError` instead of `PHPUnit_Framework_Error`
Closed
This was referenced Sep 28, 2016
Closed
Closed
|
@kleisauke I think it would be best to create a Fcm folder and just duplicate everything and then change the endpoint url. It does not feel "right" to have a Gcm client pointing to the Fcm endpoint. Just a thought. I would also love to have FCM support. @mwillbanks |
|
I've added a develop branch against #27 I will be rebasing this against that and resolving any conflicts. I hope that I can get this completed today. |
|
This has been merged to the develop branch for the next release. |
|
@kleisauke I agreed with @bathan to add new folder for FCM. |
|
I'll merge it to master and release today. Sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.