Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

[SHOP-12928] Updating URL Builder to V2 SDK #32

Closed

Conversation

physik932
Copy link

Probably need a template for this.

@YesThatAllen YesThatAllen mentioned this pull request Aug 23, 2019
@YesThatAllen
Copy link
Contributor

When I try to upload this, I get the error;

assets/iframe.html is either an invalid location URI, refers to a missing asset, or does not use HTTPS.

if i replace assets/ with templates/ then the error changes to :

assets/iframe.html is either an invalid location URI…

but still errors.

the syntax in the manifest.json looks similar to suggested code here:
https://developer.zendesk.com/apps/docs/developer-guide/manifest

I'm curios to hear of others' success or failure with this code.

@physik932
Copy link
Author

physik932 commented Aug 23, 2019

Hey @YesThatAllen , sorry bout this. I made this PR thinking it would be to the fork and not appear here. I'm still currently working on the update, as our company uses Zendesk and this plugin is integral to our workflow. At the moment we're going to come back around to working on this later, but still before the October deadline.

I'll reach out with a fresh PR once we've completed the update on our end. Thanks!

@physik932 physik932 closed this Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants