Skip to content

Commit

Permalink
Resolve test failures and warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
orien committed Jan 10, 2025
1 parent 0ce373e commit 9d8472d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion test/lib/samson/secrets/vault_server_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
it "is invalid with an invalid cert" do
server.ca_cert = "nope"
refute_valid server
server.errors.full_messages.must_equal ["Ca cert is invalid: PEM_read_bio_X509: no start line"]
server.errors.full_messages.must_equal(
["Ca cert is invalid: PEM_read_bio_X509: no start line (Expecting: CERTIFICATE)"]
)
end

it "is invalid with duplicate name" do
Expand Down
2 changes: 1 addition & 1 deletion test/models/job_queue_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ def with_staggering_enabled(stagger_interval: 1.second, &block)
mock_timer_task = mock(execute: true)
expected_task_params = {now: true, timeout_interval: 10, execution_interval: 1.second}
instance.expects(:dequeue_staggered_job)
Concurrent::TimerTask.expects(:new).with(expected_task_params).yields.returns(mock_timer_task)
Concurrent::TimerTask.expects(:new).with(**expected_task_params).yields.returns(mock_timer_task)

with_staggering_enabled do
instance.send(:start_staggered_job_dequeuer)
Expand Down

0 comments on commit 9d8472d

Please sign in to comment.