Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible account handling #1084

Open
Robiquet opened this issue Apr 19, 2023 · 8 comments
Open

Incompatible account handling #1084

Robiquet opened this issue Apr 19, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@Robiquet
Copy link
Member

polkadot-js/extension#1250

@Robiquet Robiquet added the bug Something isn't working label Apr 19, 2023
@lsaether
Copy link
Member

lsaether commented May 2, 2023

@ltfschoen Can you provide us more info for this issue? Thanks!

@ltfschoen
Copy link
Contributor

polkadot-js/extension#1250 (comment)

polkadot-js/extension#1250 (comment)

dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

@Robiquet
Copy link
Member Author

Robiquet commented May 2, 2023

polkadot-js/extension#1250 (comment)

polkadot-js/extension#1250 (comment)

dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

@Robiquet
Copy link
Member Author

Robiquet commented May 2, 2023

i had a quick glance, maybe take a look here

https://github.com/zeitgeistpm/ui/blob/staging/lib/hooks/queries/useAccountAssetBalances.ts

https://github.com/zeitgeistpm/ui/blob/staging/lib/state/wallet.ts

https://github.com/polkadot-js/common/blob/master/packages/util-crypto/src/address/encode.ts

Sorry I'm not following, I'm trying to reproduce the issue but I'm not sure how to create an Ethereum account in the Polkadot js wallet. Do you have any information on that?

@ltfschoen
Copy link
Contributor

polkadot-js/extension#1250 (comment)
polkadot-js/extension#1250 (comment)
dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

personally i don't create ethereum accounts using polkadot.js. try creating them using desktop software that creates Ethereum addresses on an air-gapped local machine. verify that your download of that desktop software hasn't been compromised

@Robiquet
Copy link
Member Author

Robiquet commented May 2, 2023

polkadot-js/extension#1250 (comment)
polkadot-js/extension#1250 (comment)
dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

personally i don't create ethereum accounts using polkadot.js. try creating them using desktop software that creates Ethereum addresses on an air-gapped local machine. verify that your download of that desktop software hasn't been compromised

Is it possible to get some steps to reproduce the issue you were seeing?

@ltfschoen
Copy link
Contributor

polkadot-js/extension#1250 (comment)
polkadot-js/extension#1250 (comment)
dapps need to filter based on chain type. so maybe have to filter Ethereum H160 addresses differently than for Substrate H256 addresses.

How did you create an Ethereum wallet in your polkadot js?

personally i don't create ethereum accounts using polkadot.js. try creating them using desktop software that creates Ethereum addresses on an air-gapped local machine. verify that your download of that desktop software hasn't been compromised

Is it possible to get some steps to reproduce the issue you were seeing?

all the steps are written at this link #1084 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants