gpui: Fix update_window
to borrow_mut
will crash on Windows
#24545
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
When we use
window_handle
to draw WebView on Windows, this will crash by:This error caused by when used WebView2.
Try this tauri-apps/wry#1383 on Windows can replay the crash.
In fact, we had done a similar fix around August last year, but we used the unsafe method to avoid crashes in that version, we felt that it was not a good change, so we do not make PR.
Today @sunli829 thought about it again and changed the method. Now using
try_borrow_mut
is similar to the previousborrow_mut
.zed/crates/gpui/src/app.rs
Lines 70 to 78 in 691de6b
I have tested to start Zed by those changes, it is looks no problem.