workspace: Fix inconsistent paths order serialization #19232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeviant
changed the title
mrnugget
approved these changes
Oct 17, 2024
Comment on lines
+1129
to
+1131
| // todo: should probably move this logic to a method on the SerializedWorkspaceLocation | ||
| // it's only valid for Local and would be more clear there and be able to be tested | ||
| // and reused elsewhere |
There was a problem hiding this comment.
Yeah, I agree with that. Either move it onto the type, or move it into the and_then block above there.
There was a problem hiding this comment.
Thanks, I'm working on a follow-up PR to tidy things up, just wanted to get the fix in for now! ^^
1 task
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
…#19232) Release Notes: - Fixed inconsistent serialization of workspace paths order
osiewicz
pushed a commit
that referenced
this pull request
Oct 22, 2024
Release Notes: - Fixed inconsistent serialization of workspace paths order
notpeter
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: