Skip to content

Commit

Permalink
chore: Improve dev build startup time
Browse files Browse the repository at this point in the history
RustEmbed repeatedly compiled regexes for handling of 'include='/'exclude' statements in a hot loop, which caused each call to Assets::iter() to take 600ms. Since it is being called twice on our startup path, that alone contributed over a second to startup time in debug builds. I've filed a PR with them pyrossh/rust-embed#244 which brings down the time for a single iter() call to 6ms.
  • Loading branch information
osiewicz committed May 11, 2024
1 parent b8a8344 commit 5afa3aa
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ refineable = { path = "./crates/refineable" }
regex = "1.5"
repair_json = "0.1.0"
rusqlite = { version = "0.29.0", features = ["blob", "array", "modern_sqlite"] }
rust-embed = { version = "8.0", features = ["include-exclude"] }
rust-embed = { version = "8.4", features = ["include-exclude"] }
schemars = "0.8"
semver = "1.0"
serde = { version = "1.0", features = ["derive", "rc"] }
Expand Down
2 changes: 1 addition & 1 deletion crates/languages/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ node_runtime.workspace = true
project.workspace = true
regex.workspace = true
rope.workspace = true
rust-embed = "8.2.0"
rust-embed.workspace = true
serde.workspace = true
serde_json.workspace = true
settings.workspace = true
Expand Down

0 comments on commit 5afa3aa

Please sign in to comment.