revert(planner/nodejs): Implement multi-layer build for Node.js (#418)

#### Description (required)

There are some modules that needs the source code tree. Therefore, we
will not only copy `.medusa/server` now.

This reverts commit 4c59e19.

#### Related issues & labels (optional)

- Experiments
- Suggested label: enhancement

internal/nodejs/node.go

@@ -18,11 +18,9 @@ type TemplateContext struct {
 
 	AppDir string
 
-	InstallCmd      string
-	BuildCmd        string
-	BuildRuntimeCmd string // currently only used by Medusa
-	StartCmd        string
-	RuntimeBaseDir  string // currently only used by Medusa
+	InstallCmd string
+	BuildCmd   string
+	StartCmd   string
 
 	Framework  string
 	Serverless bool
@@ -53,16 +51,14 @@ func (c TemplateContext) Execute() (string, error) {
 
 func getContextBasedOnMeta(meta types.PlanMeta) TemplateContext {
 	context := TemplateContext{
-		NodeVersion:     meta["nodeVersion"],
-		AppDir:          meta["appDir"],
-		InstallCmd:      meta["installCmd"],
-		BuildCmd:        meta["buildCmd"],
-		BuildRuntimeCmd: meta["buildRuntimeCmd"],
-		StartCmd:        meta["startCmd"],
-		RuntimeBaseDir:  meta["runtimeBaseDir"],
-		Framework:       meta["framework"],
-		Serverless:      meta["serverless"] == "true",
-		OutputDir:       meta["outputDir"],
+		NodeVersion: meta["nodeVersion"],
+		AppDir:      meta["appDir"],
+		InstallCmd:  meta["installCmd"],
+		BuildCmd:    meta["buildCmd"],
+		StartCmd:    meta["startCmd"],
+		Framework:   meta["framework"],
+		Serverless:  meta["serverless"] == "true",
+		OutputDir:   meta["outputDir"],
 
 		// The flag specific to planner/bun.
 		Bun:        meta["bun"] == "true" || meta["packageManager"] == "bun",

internal/nodejs/node_test.go

@@ -63,23 +63,3 @@ func TestGetContextBasedOnMeta_WithOutputdirAndMPAFramework(t *testing.T) {
 		OutputDir:   "dist",
 	})
 }
-
-func TestGetContextBasedOnMeta_RuntimeEnvironment(t *testing.T) {
-	meta := getContextBasedOnMeta(types.PlanMeta{
-		"nodeVersion":     "16",
-		"installCmd":      "RUN npm install",
-		"buildCmd":        "npm run build",
-		"buildRuntimeCmd": "npm run build-runtime",
-		"startCmd":        "npm run start",
-		"runtimeBaseDir":  "/src/.output",
-	})
-
-	assert.Equal(t, meta, TemplateContext{
-		NodeVersion:     "16",
-		InstallCmd:      "RUN npm install",
-		BuildCmd:        "npm run build",
-		BuildRuntimeCmd: "npm run build-runtime",
-		StartCmd:        "npm run start",
-		RuntimeBaseDir:  "/src/.output",
-	})
-}

internal/nodejs/plan.go

@@ -677,42 +677,27 @@ func GetBuildCmd(ctx *nodePlanContext) string {
 		}
 	}
 
-	*cmd = optional.Some(buildCmd)
-	return cmd.Unwrap()
-}
-
-// GetRuntimeBaseDir gets the base directory of the runtime environment of the Node.js app.
-func GetRuntimeBaseDir(ctx *nodePlanContext) string {
-	framework := DetermineAppFramework(ctx)
-
-	if framework == types.NodeProjectFrameworkMedusa {
-		return "/src/.medusa/server"
-	}
-
-	return ""
-}
-
-// GetBuildRuntimeCmd gets the build command to build the runtime environment of the Node.js app.
-func GetBuildRuntimeCmd(ctx *nodePlanContext) string {
-	pkgManager := DeterminePackageManager(ctx)
-	framework := DetermineAppFramework(ctx)
-
 	if framework == types.NodeProjectFrameworkMedusa {
+		var installCmd string
 		switch pkgManager {
 		case types.NodePackageManagerNpm:
-			return "npm install"
+			installCmd = "npm install"
 		case types.NodePackageManagerPnpm:
-			return "pnpm install"
+			installCmd = "pnpm install"
 		case types.NodePackageManagerYarn:
-			return "yarn install"
+			installCmd = "yarn install"
 		case types.NodePackageManagerBun:
-			return "bun install"
+			installCmd = "bun install"
 		default:
-			return "yarn install"
+			installCmd = "yarn install"
 		}
+
+		// Install the dependencies in ".medusa/server" directory.
+		buildCmd += " && " + "cd .medusa/server" + " && " + installCmd
 	}
 
-	return ""
+	*cmd = optional.Some(buildCmd)
+	return cmd.Unwrap()
 }
 
 // GetMonorepoAppRoot gets the app root of the monorepo project in the Node.js project.
@@ -852,6 +837,9 @@ func GetStartCmd(ctx *nodePlanContext) string {
 		if predeployScript != "" {
 			startCmd = GetScriptCommand(ctx, predeployScript) + " && " + startCmd
 		}
+		if framework == types.NodeProjectFrameworkMedusa {
+			startCmd = "cd .medusa/server" + " && " + startCmd
+		}
 
 		*cmd = optional.Some(startCmd)
 		return cmd.Unwrap()
@@ -1094,16 +1082,6 @@ func GetMeta(opt GetMetaOptions) types.PlanMeta {
 	startCmd := GetStartCmd(ctx)
 	meta["startCmd"] = startCmd
 
-	runtimeBaseDir := GetRuntimeBaseDir(ctx)
-	if runtimeBaseDir != "" {
-		meta["runtimeBaseDir"] = runtimeBaseDir
-	}
-
-	buildRuntimeCmd := GetBuildRuntimeCmd(ctx)
-	if buildRuntimeCmd != "" {
-		meta["buildRuntimeCmd"] = buildRuntimeCmd
-	}
-
 	// only set outputDir if there is no start command
 	// (because if there is, it shouldn't be a static project)
 	if startCmd == "" {

internal/nodejs/templates/template.Dockerfile

@@ -34,14 +34,6 @@ COPY --from=build /src/{{ .AppDir }}/{{ .OutputDir }} /
 FROM zeabur/caddy-static AS runtime
 COPY --from=output / /usr/share/caddy
 {{ end }}
-{{ else if ne .RuntimeBaseDir "" }}
-FROM build AS prod
-COPY --from=build {{ .RuntimeBaseDir }} /app/
-WORKDIR /app
-
-EXPOSE 8080
-RUN {{ .BuildRuntimeCmd }}
-CMD {{ .StartCmd }}
 {{ else }}
 EXPOSE 8080
 CMD {{ .StartCmd }}{{ end }}

tests/real_project_test.go

@@ -279,6 +279,11 @@ var projects = []struct {
 		owner: "medusajs",
 		repo:  "medusa-starter-default",
 	},
+	{
+		name:  "nodejs-medusa-zb",
+		owner: "zeabur",
+		repo:  "medusa-starter-default",
+	},
 	{
 		name: "nodejs-a-lot-of-dependencies",
 		dir:  "nodejs-a-lot-of-dependencies",

tests/snapshots/nodejs-medusa-zb.txt

@@ -0,0 +1,11 @@
+PlanType: nodejs
+
+Meta:
+  appDir: ""
+  buildCmd: "yarn build && cd .medusa/server && yarn install"
+  bun: "false"
+  framework: "medusa"
+  installCmd: "COPY . .\nRUN yarn install"
+  nodeVersion: "20"
+  packageManager: "yarn"
+  startCmd: "cd .medusa/server && yarn predeploy && yarn start"

tests/snapshots/nodejs-medusa.txt

@@ -2,12 +2,10 @@ PlanType: nodejs
 
 Meta:
   appDir: ""
-  buildCmd: "yarn build"
-  buildRuntimeCmd: "yarn install"
+  buildCmd: "yarn build && cd .medusa/server && yarn install"
   bun: "false"
   framework: "medusa"
   installCmd: "COPY . .\nRUN yarn install"
   nodeVersion: "20"
   packageManager: "yarn"
-  runtimeBaseDir: "/src/.medusa/server"
-  startCmd: "yarn start"
+  startCmd: "cd .medusa/server && yarn start"