Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New {file} formatter #552

Closed
wants to merge 2 commits into from

Conversation

psprint
Copy link
Contributor

@psprint psprint commented Jul 30, 2023

Description

I'm refreshing the old pr #421 taking into account @vladdoster's objections about the number of colors used to highlight (now there is 1 color for extensions instead of 2). Also, a new feature – highlighting of the version number (like e.g. v1.5). Furthermore, I'm submitting a branch that's on top of #550 , after merging this PR the commits will disappear from this PR.

Related Issue(s)

#421

Motivation and Context

The flexibility behind +zinit-message allows for sophisticated highlighters. Here the {file} style gets a private function-highlighter to color file extensions and version automatically with a distinct color.

Usage examples

Default theme:
2023-07-30-154441_1901x252_scrot

Blue theme:
2023-07-30-154422_1895x231_scrot

Gold theme:
2023-07-30-154502_1894x249_scrot

How Has This Been Tested?

Via the above invocations of +zinit-message interactively.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@psprint
Copy link
Contributor Author

psprint commented Jul 30, 2023

@vladdoster @pschmitt @alichtman ping :)

@psprint psprint changed the title File formatter new New {file} formatter Jul 30, 2023
@psprint
Copy link
Contributor Author

psprint commented Aug 19, 2023

@vladdoster: ping, The version coloring is cool and should be merged

@vladdoster vladdoster closed this Jan 14, 2024
@zdharma-continuum zdharma-continuum locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants