Dynamic completion #406
Closed
Dynamic completion #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psprint
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
|
I've also added a description to README. |
|
Could the PR be merged? |
psprint
force-pushed
the
dynamic-completion
branch
from
d141d5e to
452b095
Compare
|
Could the PR be merged? |
Alias all plugins with ~plgname to point to their directory.
psprint
force-pushed
the
dynamic-completion
branch
2 times, most recently
from
e1291fa to
883275a
Compare
|
I've cleanup the PR (squash and 'feat:" prefix), could it be merged? |
One will be able to obtain, e.g.:
zinit fzf<Alt>-<Shift>-A
» zinit junegunn/fzf
zinit cd rip<Alt>-<Shift>-A
» zinit cd BurntSushi/ripgrep
and so on. The <Alt>-<Shift>-A shortcut works with ALL commands,
regardless if it's zinit command or not.
Two autoloaded functions added, ziactioncomplete (the proper imple-
mentation of the main features) and ziprocessbuffer (a very useful
library function that takes care of $BUFFFER/$CURSOR processing).
Also Feature: Cycling and ice-completion (<Alt>-<Shift>-C).
Cycling will allow to choose a particular match, say for, e.g.:
zinit at<Alt>-<Shift>-C
» zinit atclone<Alt><Shift>-C
» zinit atinit<Alt>-<Shift>-C
psprint
force-pushed
the
dynamic-completion
branch
from
883275a to
38ddf2d
Compare
|
Is there any obstacle to merge the commit? It's an isolated change – active at prompt, live – it cannot break anything… |
|
@vladdoster Could the PR be merged as an Xmas gift? A mention of this could be added to README.md. |
|
@vladdoster @pschmitt @jankatins ping for merging this PR, presentation: |
This was referenced Dec 28, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete plugin ids at any position in the command line via
Alt-Shift-Aand ices viaAlt-Shift-C. Both keys are unbound by default, and can be customized via two zstyles, e.g.:Motivation and Context
Current normal completion doesn't work with
for-syntax – it'll not complete plugin id for, e.g.:While the new, action-complete, will work at any position.
Related Issue(s)
Closes #331.
Usage examples
See: https://asciinema.org/a/3bzyTIEXN4iNiDLyRAARcDypt
Types of changes
Checklist: