fix: update gh-r unit tests #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladdoster
force-pushed
the
fix/unit-tests
branch
from
3242953 to
f92e7e1
Compare
vladdoster
force-pushed
the
fix/unit-tests
branch
from
f92e7e1 to
9b25c1a
Compare
5 tasks
vladdoster
force-pushed
the
fix/unit-tests
branch
3 times, most recently
from
226d09c to
4f69040
Compare
vladdoster
force-pushed
the
fix/unit-tests
branch
from
1139a69 to
d6b5845
Compare
vladdoster
force-pushed
the
fix/unit-tests
branch
2 times, most recently
from
de0553e to
a787df9
Compare
Fixes issueZunit parsing would sometimes leak the Vim fold descriptions. AFAIK it did not affect test correctness but looked bad. An example is shown below Before
After
|
vladdoster
force-pushed
the
fix/unit-tests
branch
2 times, most recently
from
ff59ea0 to
2ad0bb4
Compare
vladdoster
commented
Oct 30, 2022
| @@ -1451,6 +1451,34 @@ builtin source "${ZINIT[BIN_DIR]}/zinit-side.zsh" || { | |||
|
|
|||
| return $? | |||
| } # ]]] | |||
|
|
|||
| # FUNCTION: .zinit-single-line [[[ | |||
There was a problem hiding this comment.
Allows this code to be compiled and removes file containing only one function.
| @@ -2359,7 +2384,7 @@ for its found {file}meson.build{pre} input file}:-because {flag}m{pre} \ | |||
| ∞zinit-make-hook() { | |||
| ∞zinit-make-base-hook "$@" "" | |||
| } # ]]] | |||
| # FUNCTION: ∞zinit-make-hook [[[ | |||
| # FUNCTION: ∞zinit-make-base-hook [[[ | |||
There was a problem hiding this comment.
Fixed a typo creating a duplicate of a different function causing docs to be incorrect.
Comment on lines
+1317
to
+1251
| 1. call the zsh plugin's standard *_plugin_unload function | ||
| 2. call the code provided by the zsh plugin's standard @zsh-plugin-run-at-update | ||
| 3. delete bindkeys (...) | ||
| 4. delete zstyles | ||
| 5. restore options | ||
| 6. remove aliases | ||
| 7. restore zle state | ||
| 8. unfunction functions (created by plugin) | ||
| 9. clean-up fpath and path | ||
| 10. delete created variables | ||
| 11. forget the plugin |
doc/zsdoc/zinit-autoload.zsh.adoc
Outdated
| @@ -1383,7 +1367,7 @@ Called by: | |||
|
|
|||
| ____ | |||
|
|
|||
| FUNCTION: .zinit-update-in-parallel [[[ | |||
| FUNCTION: .zinit-update-all-parallel [[[ | |||
doc/zsdoc/zinit-install.zsh.adoc
Outdated
| @@ -815,7 +883,7 @@ Not called by script or any function (may be e.g. a hook, a Zle widget, etc.). | |||
|
|
|||
| ____ | |||
|
|
|||
| FUNCTION: ∞zinit-reset-opt-hook [[[ | |||
| FUNCTION: ∞zinit-reset-hook [[[ | |||
doc/zsdoc/zinit.zsh.adoc
Outdated
| @@ -198,7 +239,7 @@ Called by: | |||
|
|
|||
| ____ | |||
|
|
|||
| FUNCTION: -zinit_scheduler_add_sh. [[[ | |||
| FUNCTION: -zinit_scheduler_add_sh [[[ | |||
| docker build --tag=ghcr.io/zdharma-continuum/zinit:latest --file=docker/Dockerfile . | ||
|
|
||
| doc: clean | ||
| cd doc; zsh -l -d -f -i -c "zsd -v --scomm --cignore '(\#*FUNCTION:[[:space:]][\:\∞\.\+\@\-a-zA-Z0-9]*[\[]*|}[[:space:]]\#[[:space:]][\]]*)' $(DOC_SRC)" |
There was a problem hiding this comment.
Correctly filters out verbiage from docs
FUNCTION: .zinit-compute-ice [[[
| @@ -1451,6 +1454,32 @@ builtin source "${ZINIT[BIN_DIR]}/zinit-side.zsh" || { | |||
|
|
|||
| return $? | |||
| } # ]]] | |||
| # FUNCTION: .zinit-single-line [[[ | |||
| # Display cURL progress bar on a single line | |||
| .zinit-single-line() { | |||
There was a problem hiding this comment.
@psprint Does this seem reasonable? I am moving this code from its own file (i.e., share/single-line.zsh) into a function with the rest of the Zinit code.
There was a problem hiding this comment.
I'm not sure, if it works then I guess it's fine.
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
- Add 'container' target to build local docker image - Add 'zinit-additional' to be included in zcompile & doc generation - Build local zinit image before `doc/container` - Sort targets alphabetically Signed-off-by: Vladislav Doster <[email protected]>
Documentation now includes code in `zinit-additional.zsh` Signed-off-by: Vladislav Doster <[email protected]>
Move code in `share/single-line.zsh` into function within `zinit-install.zsh`. Additionally, allows for code to be compiled. Signed-off-by: Vladislav Doster <[email protected]>
Temporarily disable container and installer workflows so CI checks pass. Fixes for both are a WIP and will be in a seperate PR that also re-enables the workflows. Signed-off-by: Vladislav Doster <[email protected]>
- Fix function typos in asciidoc comments - Fix asciidoc fold markers - Fix function args typos/style in asciidoc comments Signed-off-by: Vladislav Doster <[email protected]>
Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
fix/unit-tests
branch
from
2ad0bb4 to
c93a3ce
Compare
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladislav Doster [email protected]