Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bridge dispatcher and exporter #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

svyatonik
Copy link
Collaborator

The fully working bridge may be started by using branches, mentioned in paritytech/parity-bridges-common#2547. I'm going to open multiple PRs to make it easier to review - some PRs need a different set of reviewers

This PR adds message dispatcher for inbound messages and exporter for outbound messages. Two differences with our "regular" configuration:

  • inbound messages are not pushed onto some queue (because there are no any queues in runtime), but instead are dispatched immediately;
  • because of that ^^^, there's a need for computing dispatch weight using XcmExecutor, hence the WithXcmWeightDispatcher.

@acatangiu @bkontur @serban300 Please, take a look.

Copy link

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

runtime/src/xcm_config.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I am just curious, maybe I've missed that somewhere,
I see type MessageExporter = ToBridgeHubPolkadotHaulBlobExporter;,
so just one question, what kind of calls will send this chain to the BridgeHub?

@svyatonik
Copy link
Collaborator Author

lgtm,

I am just curious, maybe I've missed that somewhere, I see type MessageExporter = ToBridgeHubPolkadotHaulBlobExporter;, so just one question, what kind of calls will send this chain to the BridgeHub?

I have been said that they'll be calling some stuff on that new Polkadot parachain (referenced as Kawabunga here). So probably also Transact without any fees. For now I've just added an option to send messages and then we may need to fix something at Polkadot.BH (barriers?) when we'll have a messages and it'll be close to deployment. Right now I only care about adding a transport - when the app on top of that transport will be ready, we'll see.

@svyatonik
Copy link
Collaborator Author

@zdave-parity When you have a moment, please review and approve if it is ok - we need an approval to merge. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants