Updates and fixes for vue 3 #1
Conversation
| "presets": [ |
There was a problem hiding this comment.
Not 100% sure why I needed to do this, but the ES6 style import statements were complaining about not being able to find a default export, until I made this change.
| scrolling: "no", | ||
| referrerpolicy: "no-referrer-when-downgrade", | ||
| }, | ||
| src: this.frameUrl(), |
There was a problem hiding this comment.
I'm not sure if this was due to Vue2->Vue3, but with attrs as an object, it was appearing as attrs='[Object object]' on the iframe tag, rather than as the individual attributes.
There was a problem hiding this comment.
Maybe related, but it looks like people were running into a similar issue with the vue router when upgrading 2 -> 3. Either way your fix seems like the way to go.
src/index.js
Outdated
| @@ -1,3 +1,5 @@ | |||
| import { h } from 'vue'; | |||
|
|
|||
| const SDK_VERSION = "1.0.1"; | |||
There was a problem hiding this comment.
Do we want to bump this a major version? (Maybe 3 to match Vue?)
There was a problem hiding this comment.
Yep, good catch, forgot to bump it.
| scrolling: "no", | ||
| referrerpolicy: "no-referrer-when-downgrade", | ||
| }, | ||
| src: this.frameUrl(), |
There was a problem hiding this comment.
Maybe related, but it looks like people were running into a similar issue with the vue router when upgrading 2 -> 3. Either way your fix seems like the way to go.
This PR contains fixes that got the Berbix Vue integration working locally with Vue 3.
I think we'll need to maintain this as a separate branch so as not to break existing Vue 2 integrations.
I haven't used Vue before, so please correct me if there's an easier approach here. I did see the vue-compat package on NPM, but I believe that's something the app developer would need to incorporate, and not our SDK.