Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValueCommitTrapdoor::to_bytes #439

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to Rust's notion of

## [Unreleased]

### Added
- `orchard::value::ValueCommitTrapdoor::to_bytes`

## [0.10.0] - 2024-10-02

### Changed
Expand Down
10 changes: 10 additions & 0 deletions src/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,16 @@ impl ValueCommitTrapdoor {
pub fn from_bytes(bytes: [u8; 32]) -> CtOption<Self> {
pallas::Scalar::from_repr(bytes).map(ValueCommitTrapdoor)
}

/// Returns the byte encoding of this trapdoor.
///
/// This is a low-level API, requiring a detailed understanding of the
/// [use of value commitment trapdoors][orchardbalance] in the Zcash protocol
/// to use correctly and securely. It is intended to be used in combination
/// with [`ValueCommitment::derive`], and PCZTs.
pub fn to_bytes(&self) -> [u8; 32] {
self.0.to_repr()
}
}

impl Add<&ValueCommitTrapdoor> for ValueCommitTrapdoor {
Expand Down
Loading