Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label Consensus Rules #323

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Label Consensus Rules #323

merged 2 commits into from
Nov 29, 2023

Conversation

defuse
Copy link
Contributor

@defuse defuse commented May 5, 2022

No description provided.

str4d
str4d reviewed May 5, 2022
View reviewed changes
@defuse defuse force-pushed the nu5-consensus-labeled branch from d152282 to e895757 Compare July 14, 2022 21:03
@defuse defuse force-pushed the nu5-consensus-labeled branch from e895757 to 7c83d6d Compare July 21, 2022 20:40
@codecov-commenter
Copy link

Codecov Report

Merging #323 (2d15aea) into main (3faab98) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          37       37           
  Lines        3858     3858           
=======================================
  Hits         3430     3430           
  Misses        428      428
Impacted Files Coverage Δ
src/bundle.rs 41.72% <ø> (ø)
src/bundle/batch.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faab98...2d15aea. Read the comment docs.

@daira daira marked this pull request as ready for review July 28, 2022 20:08
@r3ld3v r3ld3v added this to the Release 5.3.0 milestone Aug 2, 2022
@daira daira removed this from the Release 5.3.0 milestone Sep 19, 2022
@daira daira added this to the Release 5.4.0 milestone Oct 9, 2022
@daira daira modified the milestones: Release 5.4.0, Release 5.5.0 Jan 26, 2023
@nuttycom nuttycom removed this from the Release 5.5.0 milestone Jan 30, 2023
@nuttycom nuttycom added this to the Documentation backlog milestone Jun 7, 2023
str4d
str4d approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. The TCR:* anchors haven't been added to the protocol spec yet, but we should just go ahead and merge this, and separately update the protocol spec with everything needed.

@str4d str4d merged commit 4bb65b9 into zcash:main Nov 29, 2023
@Obinna26
Copy link

God bless you Sir🙏🙏 @defuse will you mind if I plead to share some challenge I have been having on some points of the project 🙏💯 Much blessings ❤️❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Documentation backlog
Development

Successfully merging this pull request may close these issues.
7 participants
@defuse @codecov-commenter @Obinna26 @str4d @nuttycom @daira @r3ld3v