Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Host.Nats] Transport for Nats.io #287

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

dblanchetatlectra
Copy link
Contributor

@dblanchetatlectra dblanchetatlectra commented Aug 1, 2024

Nats.io transport added
Support for Pub/Sub and Request/Response functionalities

@dblanchetatlectra dblanchetatlectra force-pushed the feature/transport-for-nats branch 4 times, most recently from dfc2652 to ee8d7b2 Compare August 1, 2024 11:50
@dblanchetatlectra dblanchetatlectra changed the title feature: [Host.Nats] Transport for Nats.io #286 feature: [Host.Nats] Transport for Nats.io Aug 1, 2024
@dblanchetatlectra dblanchetatlectra changed the title feature: [Host.Nats] Transport for Nats.io [Host.Nats] Transport for Nats.io Aug 1, 2024
@dblanchetatlectra dblanchetatlectra force-pushed the feature/transport-for-nats branch from ee8d7b2 to c1057bd Compare August 1, 2024 12:13
.github/workflows/build.yml Outdated Show resolved Hide resolved
@dblanchetatlectra dblanchetatlectra force-pushed the feature/transport-for-nats branch from c1057bd to 0774ece Compare August 1, 2024 17:11
.github/workflows/build.yml Outdated Show resolved Hide resolved
docs/provider_nats.md Outdated Show resolved Hide resolved
@zarusz
Copy link
Owner

zarusz commented Aug 1, 2024

@dblanchetatlectra I've reviewed the PR - looks good.
Please check some minor comments, and see if there is an opportunity to reduce the new sonar issues.

@dblanchetatlectra dblanchetatlectra force-pushed the feature/transport-for-nats branch 3 times, most recently from d0e87d2 to 88a10e2 Compare August 3, 2024 08:02
@dblanchetatlectra dblanchetatlectra force-pushed the feature/transport-for-nats branch from 88a10e2 to 3c18415 Compare August 3, 2024 08:05
@dblanchetatlectra dblanchetatlectra force-pushed the feature/transport-for-nats branch from 3c18415 to 80b9022 Compare August 3, 2024 08:08
Copy link

sonarqubecloud bot commented Aug 3, 2024

@zarusz
Copy link
Owner

zarusz commented Aug 3, 2024

@dblanchetatlectra after the changes it looks good to me.

Do you plan any further changes or shall I merge?

@dblanchetatlectra
Copy link
Contributor Author

@zarusz no, i'm done with this 1st version. thanks for your feedback. You can merge.

@zarusz zarusz merged commit 1a03b27 into zarusz:master Aug 4, 2024
2 checks passed
@zarusz
Copy link
Owner

zarusz commented Aug 4, 2024

It's pre-released now:
https://www.nuget.org/packages/SlimMessageBus.Host.NATS

@dblanchetatlectra thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants