Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Consolidate workflows for GitHub actions #2827

Closed

Conversation

maxrjones
Copy link
Member

It might be helpful to run the upstream and min-deps jobs as part of the main 'test' workflow in order to capture caught ImportErrors in the code coverage. Motivated by #2774 where the only missed lines are ImportErrors.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 13, 2025
@maxrjones
Copy link
Member Author

maxrjones commented Feb 13, 2025

I'm not sure why exactly the test workflow isn't running - it could require maintainer approval. This was fixed by updated the test complete job

An alternative to this approach would be to just upload a report at the end of the test-upstream-and-min-deps run, as was done for the GPU tests in #2767.

@maxrjones
Copy link
Member Author

Sorry for the noise, I'm going to close this because I think uploading a coverage report for test-upstream-and-min-deps would be a better strategy because the yaml file would be simpler even if there a more components.

@maxrjones maxrjones closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants