Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate defaults for filters, serializers and compressors in v3 #2653

Merged
merged 11 commits into from
Jan 6, 2025
Merged

Separate defaults for filters, serializers and compressors in v3 #2653

merged 11 commits into from
Jan 6, 2025

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 5, 2025 •
edited
Loading

Instead of a single v3_default_codecs key in the config, this PR adds 3 separate keys for filters, serializers and compressors.

Ideally, we could get this in the 3.0 release, because it would require some backwards-compat code if we change it later.

Builds upon #2652, but could be made independent.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • GitHub Actions have all passed

@normanrz normanrz self-assigned this Jan 5, 2025
@normanrz normanrz requested review from d-v-b and jhamman January 5, 2025 15:25
d-v-b
d-v-b reviewed Jan 5, 2025
View reviewed changes
@dstansby dstansby added this to the 3.0.0 milestone Jan 5, 2025
@normanrz normanrz requested a review from d-v-b January 5, 2025 16:23
d-v-b
d-v-b reviewed Jan 5, 2025
View reviewed changes
@normanrz normanrz requested a review from d-v-b January 5, 2025 16:41
Base automatically changed from feat/filters-prop to main January 6, 2025 15:22
d-v-b
d-v-b reviewed Jan 6, 2025
View reviewed changes
d-v-b
d-v-b reviewed Jan 6, 2025
View reviewed changes
d-v-b
d-v-b reviewed Jan 6, 2025
View reviewed changes
d-v-b
d-v-b reviewed Jan 6, 2025
View reviewed changes
@normanrz normanrz enabled auto-merge (squash) January 6, 2025 17:13
@normanrz normanrz merged commit 22634ea into main Jan 6, 2025
33 checks passed
@normanrz normanrz deleted the feat/separate-default-codecs branch January 9, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

@jhamman jhamman Awaiting requested review from jhamman

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@normanrz @d-v-b @dstansby