Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarr.storezarr.storage #2523

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Dec 1, 2024

Also discard commented out code. Code commented out without a comment doesn't help. The reason here was circular imports.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Also discard commented out code. Code commented out without a comment
doesn't help. The reason here was circular imports.
@DimitriPapadopoulos DimitriPapadopoulos changed the title zarr.store → zarr.storage zarr.storezarr.storage Dec 1, 2024
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhamman jhamman merged commit bda158a into zarr-developers:main Dec 3, 2024
26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the zarr.store branch December 4, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants