-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/narrow array name type #2499
Refactor/narrow array name type #2499
Conversation
this is a breaking change, but I think it falls into the "wart removal" category.. |
Can you add an zarr-python/src/zarr/testing/strategies.py Lines 153 to 161 in d6508b5
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No opinions on backcompat
Remove the possibility that
Array.name
isNone
. In situations whenArray.name
would beNone
(i.e., when the array is at the root of the store), it will be the empty string ''.TODO: