New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new ruff/flake8-type-checking TCH003 error #2154

Merged

jhamman merged 1 commit into zarr-developers:v3 from DimitriPapadopoulos:TCH003

Sep 6, 2024

Contributor

DimitriPapadopoulos commented Sep 6, 2024 •

edited

Loading

TCH003 Move standard library import into a type-checking block

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)


          Fix new ruff/flake8-type-checking TCH003 error

4f7caf1

TCH003 Move standard library import into a type-checking block

TomAugspurger approved these changes

View reviewed changes

Contributor

TomAugspurger commented Sep 6, 2024

I'm not sure why this wasn't caught in CI on #2150, but thanks for fixing it.

jhamman approved these changes

View reviewed changes

jhamman merged commit 59b118d into zarr-developers:v3

26 checks passed

DimitriPapadopoulos deleted the TCH003 branch

September 6, 2024 19:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet