Feature: group and array name properties #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/group-and-array-name-properties
jhamman
changed the title
normanrz
approved these changes
Jun 3, 2024
rabernat
reviewed
Jun 3, 2024
| def name(self) -> str | None: | ||
| """Array name following h5py convention.""" | ||
| if self.path: | ||
| # follow h5py convention: add leading slash |
There was a problem hiding this comment.
Is this backwards compatible with V2?
Edit, yes it is. I just tried this:
import zarr
group = zarr.group(store={})
a = group.create('foo')
a = group.create('foo', shape=(1,))
assert a.name == '/foo'
d-v-b
pushed a commit
to d-v-b/zarr-python
that referenced
this pull request
Jun 4, 2024
* feature: group and array path/name/basename properties * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1924
TODO: