Fix list of packages in mypy pre-commit environment #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Jun 1, 2024
| @@ -21,6 +21,7 @@ maintainers = [ | |||
| { name = "Ryan Abernathey" } | |||
| ] | |||
| requires-python = ">=3.10" | |||
| # If you add a new dependency here, please also add it to .pre-commit-config.yml | |||
There was a problem hiding this comment.
Thanks for adding this comment. This is a bit of a bummer but it seems there isn't a better way to keep these in sync.
jhamman
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the list of dependencies in the mypy pre-commit environment mirrors the dependencies of the package (+ any dependencies needed for tests). I also had to make a small fix in
zstd, which I think is correct?TODO: